Skip to content

ARROW-14166: [C++] update vcpkg builtin baseline#11266

Closed
coryan wants to merge 1 commit into
apache:masterfrom
coryan:ARROW-14166-update-vcpkg-builtin-baseline
Closed

ARROW-14166: [C++] update vcpkg builtin baseline#11266
coryan wants to merge 1 commit into
apache:masterfrom
coryan:ARROW-14166-update-vcpkg-builtin-baseline

Conversation

@coryan

@coryan coryan commented Sep 29, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

@coryan coryan marked this pull request as ready for review September 29, 2021 14:08
@coryan

coryan commented Sep 29, 2021

Copy link
Copy Markdown
Contributor Author

Tested locally with archery docker run python-wheel-manylinux-2014. The CI failure looks like a timeout, if there is something I can do to avoid the timeout please let me know.

@kou

kou commented Sep 29, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g nightly

@github-actions

Copy link
Copy Markdown

Revision: f84f7331a210ca8f1a3ce7be648027a0b930096c

Submitted crossbow builds: ursacomputing/crossbow @ actions-861

Task Status
centos-7-amd64 Github Actions
centos-8-amd64 Github Actions
centos-8-arm64 TravisCI
conda-clean Azure
conda-linux-gcc-py36-arm64 Azure
conda-linux-gcc-py36-cpu-r40 Azure
conda-linux-gcc-py36-cuda Azure
conda-linux-gcc-py37-arm64 Azure
conda-linux-gcc-py37-cpu-r41 Azure
conda-linux-gcc-py37-cuda Azure
conda-linux-gcc-py38-arm64 Azure
conda-linux-gcc-py38-cpu Azure
conda-linux-gcc-py38-cuda Azure
conda-linux-gcc-py39-arm64 Azure
conda-linux-gcc-py39-cpu Azure
conda-linux-gcc-py39-cuda Azure
conda-osx-arm64-clang-py38 Azure
conda-osx-arm64-clang-py39 Azure
conda-osx-clang-py36-r40 Azure
conda-osx-clang-py37-r41 Azure
conda-osx-clang-py38 Azure
conda-osx-clang-py39 Azure
conda-win-vs2017-py36-r40 Azure
conda-win-vs2017-py37-r41 Azure
conda-win-vs2017-py38 Azure
conda-win-vs2017-py39 Azure
debian-bullseye-amd64 Github Actions
debian-bullseye-arm64 TravisCI
debian-buster-amd64 Github Actions
debian-buster-arm64 TravisCI
example-cpp-minimal-build-static Github Actions
example-cpp-minimal-build-static-system-dependency Github Actions
homebrew-cpp Github Actions
homebrew-r-autobrew Github Actions
java-jars Github Actions
nuget Github Actions
python-sdist Github Actions
test-build-vcpkg-win Github Actions
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-conda-python-3.6 Github Actions
test-conda-python-3.6-pandas-0.23 Github Actions
test-conda-python-3.7 Github Actions
test-conda-python-3.7-dask-latest Github Actions
test-conda-python-3.7-dask-master Github Actions
test-conda-python-3.7-hdfs-2.9.2 Github Actions
test-conda-python-3.7-hdfs-3.2.1 Github Actions
test-conda-python-3.7-kartothek-latest Github Actions
test-conda-python-3.7-kartothek-master Github Actions
test-conda-python-3.7-pandas-0.24 Github Actions
test-conda-python-3.7-pandas-latest Github Actions
test-conda-python-3.7-spark-branch-3.0 Github Actions
test-conda-python-3.8 Github Actions
test-conda-python-3.8-hypothesis Github Actions
test-conda-python-3.8-pandas-latest Github Actions
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.8-spark-master Github Actions
test-conda-python-3.9 Github Actions
test-conda-python-3.9-pandas-master Github Actions
test-debian-11-cpp Github Actions
test-debian-11-go-1.15 Azure
test-debian-11-python-3 Azure
test-debian-c-glib Github Actions
test-debian-ruby Github Actions
test-fedora-33-cpp Github Actions
test-fedora-33-python-3 Azure
test-r-arrow-backwards-compatibility Github Actions
test-r-depsource-auto Azure
test-r-depsource-system Github Actions
test-r-devdocs Github Actions
test-r-gcc-11 Github Actions
test-r-install-local Github Actions
test-r-linux-as-cran Github Actions
test-r-linux-rchk Github Actions
test-r-linux-valgrind Azure
test-r-minimal-build Azure
test-r-offline-maximal Github Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-ubuntu-gcc-release-latest Azure
test-r-rocker-r-base-latest Azure
test-r-rstudio-r-base-3.6-bionic Azure
test-r-rstudio-r-base-3.6-centos7-devtoolset-8 Azure
test-r-rstudio-r-base-3.6-centos8 Azure
test-r-rstudio-r-base-3.6-opensuse15 Azure
test-r-rstudio-r-base-3.6-opensuse42 Azure
test-r-ubuntu-21.04 Github Actions
test-r-versions Github Actions
test-ubuntu-18.04-cpp Github Actions
test-ubuntu-18.04-cpp-release Github Actions
test-ubuntu-18.04-cpp-static Github Actions
test-ubuntu-18.04-python-3 Azure
test-ubuntu-18.04-r-sanitizer Azure
test-ubuntu-20.04-cpp Github Actions
test-ubuntu-20.04-cpp-14 Github Actions
test-ubuntu-20.04-cpp-17 Github Actions
test-ubuntu-20.04-cpp-thread-sanitizer Github Actions
test-ubuntu-20.10-docs Azure
test-ubuntu-c-glib Github Actions
test-ubuntu-default-docs Azure
test-ubuntu-ruby Github Actions
ubuntu-bionic-amd64 Github Actions
ubuntu-bionic-arm64 TravisCI
ubuntu-focal-amd64 Github Actions
ubuntu-focal-arm64 TravisCI
ubuntu-hirsute-amd64 Github Actions
ubuntu-hirsute-arm64 TravisCI
wheel-macos-big-sur-cp39-arm64 Github Actions
wheel-macos-big-sur-cp39-universal2 Github Actions
wheel-macos-big-sur-py38-arm64 Github Actions
wheel-macos-high-sierra-cp36-amd64 Github Actions
wheel-macos-high-sierra-cp37-amd64 Github Actions
wheel-macos-high-sierra-cp38-amd64 Github Actions
wheel-macos-high-sierra-cp39-amd64 Github Actions
wheel-macos-mavericks-cp36-amd64 Github Actions
wheel-macos-mavericks-cp37-amd64 Github Actions
wheel-macos-mavericks-cp38-amd64 Github Actions
wheel-macos-mavericks-cp39-amd64 Github Actions
wheel-manylinux2010-cp36-amd64 Github Actions
wheel-manylinux2010-cp37-amd64 Github Actions
wheel-manylinux2010-cp38-amd64 Github Actions
wheel-manylinux2010-cp39-amd64 Github Actions
wheel-manylinux2014-cp36-amd64 Github Actions
wheel-manylinux2014-cp36-arm64 TravisCI
wheel-manylinux2014-cp37-amd64 Github Actions
wheel-manylinux2014-cp37-arm64 TravisCI
wheel-manylinux2014-cp38-amd64 Github Actions
wheel-manylinux2014-cp38-arm64 TravisCI
wheel-manylinux2014-cp39-amd64 Github Actions
wheel-manylinux2014-cp39-arm64 TravisCI
wheel-windows-cp36-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@kou

kou commented Sep 30, 2021

Copy link
Copy Markdown
Member

Umm, there are some failures... I'm not sure the failures are related to this change...

@ianmcook Could you confirm this change?

@coryan

coryan commented Sep 30, 2021

Copy link
Copy Markdown
Contributor Author

If you think rebasing or running some tests locally can help troubleshoot this I am happy to do so.

@ianmcook

ianmcook commented Oct 1, 2021

Copy link
Copy Markdown
Member

Thanks for working on this @coryan!

test-build-vcpkg-win first started failing in the nightly Crossbow job on September 10. I have been away for some of the time since then and haven't had a chance to dig in and determine the cause. I'll try to find some time today or tomorrow to do that. We should try to get that test to pass before merging this.

@ianmcook

ianmcook commented Oct 3, 2021

Copy link
Copy Markdown
Member

I opened ARROW-14208 to fix the issue that's causing test-build-vcpkg-win to fail

@coryan

coryan commented Oct 4, 2021

Copy link
Copy Markdown
Contributor Author

Rebased to pick the fixes for ARROW-14208, though it seems that there is a separate link problem that we should wait for too?

@kou

kou commented Oct 5, 2021

Copy link
Copy Markdown
Member

@ianmcook Could you dig into the linker issue?

@ianmcook

ianmcook commented Oct 8, 2021

Copy link
Copy Markdown
Member

Jira for the linker error is ARROW-14260.

@coryan

coryan commented Oct 13, 2021

Copy link
Copy Markdown
Contributor Author

Is there something else I should do in this PR or can we merge it?

@kou

kou commented Oct 15, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-build-vcpkg-win

@github-actions

Copy link
Copy Markdown

Revision: db56ecb6d2b213b0b1931d1735c0c1f24f607aec

Submitted crossbow builds: ursacomputing/crossbow @ actions-971

Task Status
test-build-vcpkg-win Github Actions

@coryan

coryan commented Oct 26, 2021

Copy link
Copy Markdown
Contributor Author

Rebased, looks like there was a related change a few days ago.

@kou

kou commented Oct 26, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-build-vcpkg-win

@github-actions

Copy link
Copy Markdown

Revision: 154c3af

Submitted crossbow builds: ursacomputing/crossbow @ actions-1051

Task Status
test-build-vcpkg-win Github Actions

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou closed this in 61be051 Oct 28, 2021
@ursabot

ursabot commented Oct 28, 2021

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 4c2a8dd and contender = 61be051. 61be051 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️1.03% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.45% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@coryan coryan deleted the ARROW-14166-update-vcpkg-builtin-baseline branch October 28, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants